Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SSM - coordinate superposition library https://bugzilla.redhat.com/show_bug.cgi?id=435017 ------- Additional Comments From rc040203@xxxxxxxxxx 2008-05-28 01:03 EST ------- Thanks for not shipping static libs :) Several major issues: * Building in mocks fails: ... checking for MMDB... configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config. Alternatively, you may set the environment variables MMDB_CFLAGS and MMDB_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. ... => Missing "BuildRequires: mmdb-devel" * *-devel ships a *.pc => "Requires: pkgconfig" needs to be added to *-devel * Your BuildRoot: doesn't comply to the FPG. Please use one of the options described in https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * /sbin/ldconfig scriptlets missing from "main-package" cf. https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#Shared_libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review