Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tlock - terminal lock https://bugzilla.redhat.com/show_bug.cgi?id=444952 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-05-27 12:34 EST ------- For 1.2-1: * rpmlint issue - Please check your rpms by rpmlint (in rpmlint package) ------------------------------------------------------------ tlock.i386: E: info-dir-file /usr/share/info/dir tlock.i386: W: summary-not-capitalized tlock is a terminal lock tlock.i386: W: one-line-command-in-%postun /sbin/ldconfig tlock.src: W: summary-not-capitalized tlock is a terminal lock tlock.src: W: strange-permission tlock.spec 0600 tlock.src: W: strange-permission tlock-1.2.tar.gz 0600 ------------------------------------------------------------ Summary * %_infodir/dir must be removed. * Summary must begin with capital letter. Also, the description "tlock is" is redundant. * When calling /sbin/ldconfig "only" on scriptlet, write it in one line to avoid unneeded shell call by ------------------------------------------------------------ %postun -p /sbin/ldconfig ------------------------------------------------------------ * Change the permission of all files in srpm to 0644. * Parallel make - Support parallel make if possible, otherwise write on the spec file that parallel make doesn't work for this package. * %clean - "make distclean" is not needed. rpmbuild finally removes all files under %_tmppath/%name-%version and the directory itself. ! Duplicate files - Not a blocker, however the files "README COPYING" for -devel package are redundant because -devel subpackage always requires tlock package. * info files issue - After removng %_infodir/dir ------------------------------------------------------------- [root@localhost i386]# LANG=C rpm -ivh tlock-1.2-1.fc9_p.1.i386.rpm tlock-devel-1.2-1.fc9_p.1.i386.rpm Preparing... ########################################### [100%] 1:tlock ########################################### [ 50%] install-info: warning: no info dir entry in `/usr/share/info/tlock.info' 2:tlock-devel ########################################### [100%] ------------------------------------------------------------- Please verify if this warning can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review