Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SSM - coordinate superposition library https://bugzilla.redhat.com/show_bug.cgi?id=435017 ------- Additional Comments From rc040203@xxxxxxxxxx 2008-05-26 21:04 EST ------- some comments based on coarse visual inspection of the rpm.spec: MUSTFIX: - Don't ship *.la's Remove them in %install SHOULD: - %makeinstall is considered obsolete. Better use "make DESTDIR=${RPM_BUILD_ROOT} install" if feasible. CONSIDER: - Feel strongly encouraged not to ship static libraries (consider adding --disable-static to %configure) [Analogous comments also apply to further packages related to this package you currently have pending for review] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review