Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-virtkey - Python extension for emulating keypresses and getting current keyboard layout https://bugzilla.redhat.com/show_bug.cgi?id=445454 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-05-26 00:22 EST ------- Review: + package builds in mock. Koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=628436 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 7784e71e20413424ca7afa7ac9eda7fd python-virtkey-0.50.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package python-virtkey-0.50-3.fc10 => Provides: virtkey.so Requires: libX11.so.6 libXtst.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgdk-x11-2.0.so.0 libglib-2.0.so.0 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review