Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tktray - System Tray Icon Support for Tk on X11 https://bugzilla.redhat.com/show_bug.cgi?id=446978 ------- Additional Comments From lemenkov@xxxxxxxxx 2008-05-25 15:55 EST ------- Issues: * Still very long line in %description * in build section make invokes w/o %{?_smp_mflags}. If it cannot be built with %{?_smp_mflags} you must mention it. * chmod 644 license.terms in %prep section * Fix buildroot tag (according to http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 ) to mandatory value: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Seems that "Group: Applications/Communications" is wrong choice. I think that something like "Applications/System" or "User Interface/Desktops" will be more suitable. Other things looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review