Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libusb1 - A library which allows userspace access to USB devices https://bugzilla.redhat.com/show_bug.cgi?id=447745 ------- Additional Comments From bnocera@xxxxxxxxxx 2008-05-22 10:16 EST ------- Source rpmlint is clean. But: $ rpmlint libusb1-* libusb1.i386: W: no-documentation libusb1-static.i386: W: no-documentation You need to move the documentation from the -devel package to the main package. package name: ok spec file name: ok packaging guidelines: nak Just the release/source tarball problem mentioned above. license: ok license field: ok license file: ok spec file language: ok You should add a line mentioning that libsub1 isn't compatible with the original libusb-0.1. spec file legibility: ok upstream sources: nak As mentioned above. buildable: yes, runs fine in mock excludearch: n/a build deps: ok locale handling: ok ldconfig: ok relocatable: n/a directory ownership: ok duplicate files: ok file permissions: ok %clean: ok content: permissible documentation: ok, apart from the above headers: ok static libs: ok pkgconfig files: ok shared libraries: ok devel package: ok libtool archives: ok gui apps: n/a file ownership: ok %install: ok utf8 filenames: ok Would be an approval, once the problems mentioned above are fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review