Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libuninum - Library for converting unicode strings to numbers https://bugzilla.redhat.com/show_bug.cgi?id=447566 ------- Additional Comments From panemade@xxxxxxxxx 2008-05-22 03:29 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=622193 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5a34c5cf6a6307274dad0ce52b40f94c libuninum-2.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libuninum-2.7-2.fc10 -> Provides: libuninum.so.5 Requires: /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgmp.so.3 libuninum.so.5 + Package libuninum-devel-2.7-2.fc10 -> Requires: libuninum = 2.7-2.fc10 libuninum.so.5 + Not a GUI App. SHOUDLD: Change libuninum rpm group to System Environment/Libraries APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review