Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: postgresql-pgbouncer - Lightweight connection pooler for PostgreSQL https://bugzilla.redhat.com/show_bug.cgi?id=244593 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-05-21 13:50 EST ------- For 1.1.2-2: * License - For this package use "MIT and BSD" as license tag. Actually almost all source codes are under MIT, only src/md5.{h,c} are under BSD. * compile log http://koji.fedoraproject.org/koji/getfile?taskID=622998&name=build.log - Please make compile log more verbose. From outputs like ------------------------------------------------- make[1]: Leaving directory `/builddir/build/BUILD/pgbouncer-1.1.2/doc' CC src/loader.c CC src/client.c CC src/objects.c CC src/proto.c CC src/pooler.c ------------------------------------------------- we cannot check if compiler flags are passed correctly, binaries are stripped by accident, etc.. ------------------------------------------------- make %{?_smp_mflags} V=1 ------------------------------------------------- seems okay * Timestamp - When using "install" or "cp" commands, add "-p" option to keep timestamps on installed files. * Permission - Why does %_sysconfdir/sysconfig/%name have not 0644 but 0755 permission? * __os_install_post - Again from build.log currently only /usr/lib/rpm/brp-compress is executed as __os_install_post, which is wrong (you can compare with: http://koji.fedoraproject.org/koji/getfile?taskID=622988&name=build.log for example) Note: ------------------------------------------------- %{?debug:%define __os_install_post /usr/lib/rpm/brp-compress} ------------------------------------------------- means that if %debug macro _is defined_ (not is non-zero) __os_install_post is defined as /usr/lib/rpm/brp-compress. * debuginfo missing - debuginfo rpm is not correctly created * One reason is due to wrong __os_installed_post as described above * Another reason is that installed pgbouncer binary are actually stripped as "install -s". Overriding BININSTALL works for this issue. * initscript scriptlets - Please follow http://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets * Especially check "Requires(post)" or so * Documents - Please add the following files to %doc ------------------------------------------------- AUTHORS ------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review