Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-CPAN-Meta - Validation of the META.yml file in a CPAN distribution https://bugzilla.redhat.com/show_bug.cgi?id=447084 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-05-21 07:36 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=622376 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 73ae85c96261c0e92662e267a32a727c Test-CPAN-Meta-0.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=179, 0 wallclock secs ( 0.52 cusr + 0.04 csys = 0.56 CPU) + Package perl-Test-CPAN-Meta-0.10-1.fc10 => Provides: perl(Test::CPAN::Meta) = 0.10 perl(Test::CPAN::Meta::Version) = 0.10 Requires: perl(:MODULE_COMPAT_5.10.0) perl(Parse::CPAN::Meta) perl(Test::Builder) perl(Test::CPAN::Meta::Version) perl(strict) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review