Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libx86 - library for making real-mode x86 calls https://bugzilla.redhat.com/show_bug.cgi?id=447285 ------- Additional Comments From ajax@xxxxxxxxxx 2008-05-20 10:34 EST ------- - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistent macro usage. - Meets Packaging Guidelines. - License - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: 41bee1f8e22b82d82b5f7d7ba51abc2a libx86-1.1-1.fc9/libx86-1.1.tar.gz 41bee1f8e22b82d82b5f7d7ba51abc2a libx86-1.1.tar.gz - Package does not need ExcludeArch - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - Doc subpackage not needed/used. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package creates no directories. - No rpmlint output. Builds in mock locally, submitted to koji but that's being a bit laggy. The %description text is a bit misleading since you're building it with x86emu everywhere. Fix that and the %postrun typo and we'll call this approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review