Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schroot - Execute commands in a chroot environment https://bugzilla.redhat.com/show_bug.cgi?id=447368 ------- Additional Comments From rc040203@xxxxxxxxxx 2008-05-19 20:22 EST ------- Some comments based on an older schroot rpm I had written some time ago, but haven't gotten around to finish: MUSTFIX: - dchroot.1.gz belongs into the dchroot-package - These "Requires" are superfluous, please remove them: Requires: pam Requires: boost Requires: lockdev - The i18n files (aka %{_localedir]/*) belong into the packages containing libsbuild.so.* CONSIDER: - Splitting out libsbuild.so.* into a separate libsbuild package doesn't make much sense. On Debian such kind of split is technically necessary, but it isn't on rpm-based systems. - Add a *-devel package to take the devel-files. Points I am not sure about: - AFAICT, schroot needs an additional directory: /var/lib/schroot/mount My old schroot rpm didn't work without it. - I am having doubts on your schroot-remove-tmpfs-shm.patch. Why are you removing tmpfs? In my old rpm, I also patch mount-defaults, but unlike you, I keep tmpfs and remove /home and /tmp. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review