Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wgrib2 - Wgrib for GRIB-2 https://bugzilla.redhat.com/show_bug.cgi?id=438195 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ ------- Additional Comments From pertusus@xxxxxxx 2008-05-19 17:51 EST ------- (In reply to comment #2) > (In reply to comment #1) > > I did a package too, very similar with yours (strange isn't it ;-) > > I guess we both work in the earth sciences area? As strange as it may be, I am not in earth sciences (though I was trained as a biologist), I am an economist, but an economist working a lot with climate scientists (mainly on climate change consequences)... > g2clib-devel requires libpng-devel. Ok. I have 2 remarks - I think it is better to avoid naming files with fedora, to play nicer with downstream for spec files, be it only EPEL. - the -r of rm is useless These are not blockers, so: * follow packaging guidelines * match upstream 8929dd70291298b2638a6740011d82be wgrib2.tgz.v1.7.2b * free software, license included * %files section right APPROVED I'd appreciate to be in initialCC and watchcommit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review