Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GLC_lib - C++ class library for OpenGL application based on Qt 4 https://bugzilla.redhat.com/show_bug.cgi?id=446415 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ed@xxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From ed@xxxxxxx 2008-05-17 10:55 EST ------- Hi kwizart, This package seems to be in good shape: + source matches upstream sha1sum: fc893ad72f6d0e5da240c2ae963510fb34edeb82 GLC_lib_src_0_9_8.zip_UPSTREAM fc893ad72f6d0e5da240c2ae963510fb34edeb82 GLC_lib_src_0_9_8.zip + license is correct and correctly included + proper use of ldconfig + clean section and "rm -rf $RPM_BUILD_ROOT" in install + specfile is simple, clean, and macros look OK + builds in mock (F8 x86_64) + rpmlint reports two warnings which can be safely ignored: GLC_lib.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/GLC_lib-0.9.8/COPYING GLC_lib-devel.x86_64: W: no-documentation + dir ownership looks good so its APPROVED. I'll review the GLC_Player (bug # 446417) next. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review