[Bug 446390] Review Request: cluster - RedHat Cluster Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluster - RedHat Cluster Suite


https://bugzilla.redhat.com/show_bug.cgi?id=446390





------- Additional Comments From fdinitto@xxxxxxxxxx  2008-05-14 13:49 EST -------
(In reply to comment #2)
> A few additional minor items:
> 
> %postun -n cman
> /sbin/ldconfig > /dev/null
> 
> can be changed into
> 
> %postun -n cman -p /sbin/ldconfig

I have done the postun section on your suggestion but i have a question:
does this apply also to %post? google is not helping me here to find references
to this format and I don't like to do blind changes (even when i know they are
coming from trusted sources ;))
What does -p mean?

> Please avoid using file requires, except where absolutely necessary. Instead of
> Requires: net-tools mount /sbin/findfs /bin/bash
>  use
> Requires: net-tools mount e2fsprogs
> (bash is already a Requires, two lines above)

done.

> 
> Please show an updated SPEC/SRPM and I will finish the review. :)

Spec URL: http://bassotto.seabone.net/~fabbione/cluster.spec
65f4fe55f70bb14a85d83c5232d8a0f7  cluster.spec (just in case there is proxy on
the way since the URL is the same)
SRPM URL: http://bassotto.seabone.net/~fabbione/cluster-2.99.01-2.fc10.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]