Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pytrainer - A tool to log all your sport excursions https://bugzilla.redhat.com/show_bug.cgi?id=443469 katzj@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |katzj@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From katzj@xxxxxxxxxx 2008-05-14 09:23 EST ------- So the obvious first problem just from starting to look is that this isn't going to work with rawhide/F9 due to the move to xulrunner and firefox3. Working through other some of the other stuff for review, though * Requires: python will be automatically added, no need to explicitly list it * python-sqlite2 is the same API as the sqlite3 module in the stock python package... I'm actually not even sure why we keep shipping it (bug 446389) * There's no COPYING or LICENSE in the upstream tarball. It would be good to get the upstream to make that more explicit as well as ensuring the GPLv2 vs GPLv2+ * rpmlint only warns about lack of documentation, but there's not really anything in the tarball. You could leave out the blank %doc line from %files Otherwise, at least from a quick review, everything looks good. But the firefox thing might be a bit tricky :-/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review