Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: phplogcon - A syslog data viewer for the web https://bugzilla.redhat.com/show_bug.cgi?id=444722 ------- Additional Comments From tmraz@xxxxxxxxxx 2008-05-14 04:32 EST ------- A few changes will be needed: 1. rpmlint barfs rpmlint -v /home/users/tmraz/src/rpm/SRPMS/phplogcon-2.3.1-1.fc9.src.rpm phplogcon.src: I: checking phplogcon.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 30) 2. As the phplogcon is not configured when the rpm is installed I suggest to modify the apache config file so the http://<whatever>/phplogcon/ is not accessible by default at all. 3. If the install.php is removed as suggested by it when it is run, it will be readded when the phplogcon rpm is upgraded. So the sources should be patched to make install.php just being ignored when phplogcon is already configured. 4. The README.fedora should be created with notes about how it could/should be set up also there might be some notes that it preferably should be used with mysql as the source of the logs because of permissions and selinux issues when /var/log/.... files are used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review