Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tmispell-voikko - An Ispell compatible front-end for spell-checking modules https://bugzilla.redhat.com/show_bug.cgi?id=427824 ------- Additional Comments From vpivaini@xxxxxxxxxxxxxx 2008-05-12 09:21 EST ------- New Spec: http://vpv.fedorapeople.org/packages/tmispell-voikko.spec New SRPM: http://vpv.fedorapeople.org/packages/tmispell-voikko-0.7-0.6.fc8.src.rpm (In reply to comment #11) > The enchant-voikko subpackage is missing a %defattr in %files. Fixed. > When built with enchant support, does something that gets pulled in by library > dependencies own the %{_libdir}/enchant dir? Yes, the main enchant package. > Are both the versioned and unversioned %{_libdir}/enchant/*.so* needed? I did some testing. Enchant seems to expect libenchant_voikko.so (which is a symlink to libenchant_voikko.so.1.0.0), if there's only libenchant_voikko.so.1.0.0 without the symlink, it doesn't work. However, I see no use for libenchant_voikko.so.1, so that's now removed. I asked in the Voikko mailing list if it would be ok to just rename libenchant_voikko.so.1.0.0 to libenchant_voikko.so, but I haven't gotten an answer yet. Marc: If you happen to read this, any advice? The enchant-devel package seems to have the .a files for the other providers (libenchant_aspell.a and libenchant_myspell.a), so I added an enchant-voikko-devel package, which only has libenchant_voikko.a. > Also, if you like, things could be simplified a bit by replacing the toplevel > %define with "%bcond_with enchant", using %{with enchant} instead of > %{with_enchant}, and removing the %if around the enchant-voikko subpackage > definition (it's unnecessary). Thanks for the tip, I've done so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review