Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-zoo - Z's ordered observations https://bugzilla.redhat.com/show_bug.cgi?id=445635 ------- Additional Comments From alexl@xxxxxxxxxxxxxxxxxxxxx 2008-05-11 02:43 EST ------- Full review below. Show me an updated spec that addresses the issue of the BR and I should be able to quickly approve. - Package meets naming and packaging guidelines: YES - Spec file matches base package name: YES - Spec has consistant macro usage: YES - Meets Packaging Guidelines: YES - License: YES (GPLv2 as per COPYRIGHTS) - License field in spec matches: YES - License file included in package: YES (COPYING file) - Spec in American English: YES - Spec is legible: YES - Sources match upstream md5sum: YES af9f197a572233455a674a68bd7e8d9c zoo_1.5-3.tar.gz - Package needs ExcludeArch: NO - BuildRequires correct: tex(latex) NEEDS-WORK (see below) - Spec handles locales/find_lang: N/A - Package is relocatable and has a reason to be. N/A - Package has %defattr and permissions on files is good.: YES - Package has a correct %clean section. YES - Package has correct buildroot: YES %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content.: YES - Doc subpackage needed/used. N/A - Packages %doc files don't affect runtime. YES - Package is a GUI app and has a .desktop file N/A - Package compiles and builds on at least one arch. YES (see koji build above, also works on F-8) - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. YES - rpmlint output can be ignored as per http://fedoraproject.org/wiki/Packaging/R R-zoo.noarch: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh R-zoo.noarch: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh - final provides and requires are sane: Provides: R-zoo = 1.5-2.fc8 Requires: /bin/sh /bin/sh R R R SHOULD Items: - Should build in mock: YES - Should build on all supported archs: YES - Should function as described: YES (tested on F-8) - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. N/A - Should have dist tag YES - Should package latest version YES Issues: 1. Fix BuildRequires for LaTeX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review