Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Cache-Transparent - Cache the result of http get-requests persistently https://bugzilla.redhat.com/show_bug.cgi?id=444733 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-05-10 23:47 EST ------- Why the complex License: tag? "Same as Perl" is generally taken to mean "GPL+ or Artistic"; look for "Perl license" under http://fedoraproject.org/wiki/Licensing or the Perl packaging guidelines at http://fedoraproject.org/wiki/Packaging/Perl. Regardless of the comment you have in your %files section, this package should own %{perl_vendorlib}/HTTP as well. See the "File and Directory Ownership" section of http://fedoraproject.org/wiki/Packaging/Guidelines for an explanation. cpanspec should have gotten this right. * source files match upstream: 31b6b54d9488b35eb8ca54b6f5bcefd6eb1e208ca8a4038c1cee61042747f1d9 HTTP-Cache-Transparent-1.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(HTTP::Cache::Transparent) = 1.0 perl-HTTP-Cache-Transparent = 1.0-1.fc9 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Cwd) perl(Digest::MD5) perl(File::Copy) perl(File::Path) perl(HTTP::Status) perl(IO::File) perl(LWP::UserAgent) perl(strict) * %check is present and all tests pass: All tests successful. Files=3, Tests=3, 0 wallclock secs ( 0.17 cusr + 0.03 csys = 0.20 CPU) X fails to own the HTTP directory. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review