Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-pgocaml - OCaml library for type-safe access to PostgreSQL databases https://bugzilla.redhat.com/show_bug.cgi?id=275491 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-05-10 20:49 EST ------- There's a .cmo in the main package; I'm going to assume this is a syntax extension or something which otherwise needs to be included, but I guess it's possible that there's just a missing %exclude so I figured I'd ask. Since you know far more about ocaml than I, I'm not going to block on it. * source files match upstream: 9ab3808bb9f2f29bf12a80aac8ca722524b7d6e0e75a1f1a9be5058322be665a pgocaml-1.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: ocaml-pgocaml-1.1-1.fc9.x86_64.rpm ocaml(Pa_pgsql) = 6c80230157384b5460e814494ec3bfb4 ocaml(PGOCaml) = 0e086abf49f4f7dd885beda5a3f33347 ocaml(PGOCaml_config) = 3a213460288e45681958941e81d1020c ocaml(Pgocaml_prof) = 2c46f9db17216c1e2caf9b3971ddd454 ocaml-pgocaml = 1.1-1.fc9 = libpcre.so.0()(64bit) ocaml(Arg) = 03e86a4154064ea900dc32c05f53e364 ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Calendar) = bf2d533aa4bba61b1d373c5d237d52f0 ocaml(Camlp4) = 1e46a133b8062d1571640f7fa36f32c4 ocaml(Camlp4_config) = cb716b4361f43326c6ad695c7a1bb5c0 ocaml(Camlp4_import) = 0134ca95282ef6821081c0c11802cea0 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1 ocaml(Csv) = ae0aaf6ac1a19f8dfc45722e1b9f6616 ocaml(Digest) = a5dd2d89492338578de12105e88c803f ocaml(Enum) = c16e527384c2b6d71d8b19582503f5f1 ocaml(ExtList) = f0f729e9c5635a8010fc862a9c31fed4 ocaml(ExtString) = a3a294a12ef901b2e812ef847ce8c233 ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476 ocaml(Format) = 35fe566f7a37d8991a5c822bd1463949 ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Option) = 77e72c890789e19a0e7444e00377d171 ocaml(Parsing) = 62cca107e4e88af303516459a87c3e9a ocaml(Pcre) = 9cf03a45728e3cf29272c957775befee ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printexc) = 82717999a586ede6925c0aa18d6562ac ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Queue) = caa3a209bfc63d23a30f573541a88fec ocaml(Random) = 9936935480b36bcbc716ee513f37876c ocaml(Set) = 7da14e671a035f12386ace3890018ef3 ocaml(Str) = 56bb7ee61b2da83d42394686e3558fe4 ocaml(Stream) = 21a833e12efd34ea0c87d8d9da959809 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(Unix) = 9a46a8db115947409e54686ada118599 ocaml(runtime) = 3.10.1 ocaml-pgocaml-devel-1.1-1.fc9.x86_64.rpm ocaml-pgocaml-devel = 1.1-1.fc9 = ocaml-pgocaml = 1.1-1.fc9 * %check is necessarily disabled. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files (except COPYING.LIB, ok) * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .cma, .cmi, .so, .so.owner, META files in the main package. * .a, .cmxa, .cmx and .mli files are in the -devel subpackage. ? .cmo, .o and .ml files not included APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review