Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server Alias: perl-Net-FTPServer https://bugzilla.redhat.com/show_bug.cgi?id=248431 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-05-10 18:47 EST ------- I'm not taking this review so as to not steal it from Richard if he wants it, but here's a completed review checklist and some comments. Seems to me the license should be GPLv2+. The copyright notices are there in the code and documentation and have the usual "either version 2 of the License, or (at your option) any later version" language. I don't have a problem with not including the actual server executables, or with splitting them out, but if the package doesn't actually install a server, shouldn't the Summary: and %description be adjusted? Some weird stuff appears when running the tests: error: Tried to add member with zero or undef value for time at /usr/lib/perl5/vendor_perl/5.10.0/Archive/Zip/Member.pm line 487 Archive::Zip::Member::_unixToDosTime(0) called at /usr/lib/perl5/vendor_perl/5.10.0/Archive/Zip/Member.pm line 180 Archive::Zip::Member::setLastModFileDateTimeFromUnix('Net::FTPServer::ZipMember=HASH(0x145a8d0)', 0) called at /builddir/build/BUI LD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 8121 Net::FTPServer::ZipMember::_newFromFileHandle('Net::FTPServer::ZipMember', 'Net::FTPServer::InMem::FileHandle=HASH(0x14590e0)') ca lled at /builddir/build/BUILD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 4219 Net::FTPServer::__ANON__() called at /builddir/build/BUILD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 4341 Net::FTPServer::visit('Net::FTPServer::InMem::Server=HASH(0xb0f418)', 'Net::FTPServer::InMem::DirHandle=HASH(0x1450ef8)', 'HASH(0x 1450e80)') called at /builddir/build/BUILD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 4334 Net::FTPServer::visit('Net::FTPServer::InMem::Server=HASH(0xb0f418)', 'Net::FTPServer::InMem::DirHandle=HASH(0x13ffae8)', 'HASH(0x 1450e80)') called at /builddir/build/BUILD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 4243 Net::FTPServer::_archive_generator_zip('Net::FTPServer::InMem::Server=HASH(0xb0f418)', 'Net::FTPServer::InMem::DirHandle=HASH(0x13 ffae8)') called at /builddir/build/BUILD/Net-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 5362 Net::FTPServer::_RETR_command('Net::FTPServer::InMem::Server=HASH(0xb0f418)', 'RETR', 'dir.zip') called at /builddir/build/BUILD/N et-FTPServer-1.122/blib/lib/Net/FTPServer.pm line 3002 Net::FTPServer::run('Net::FTPServer::InMem::Server', 'ARRAY(0x6239f8)') called at t/350generatorzip.t line 41 This error repeats several times. Nevertheless, the tests pass. * source files match upstream: d7a5257c982edaa83b2cd5c1cbb3190a27b8f9996b382cbaa69d2c5d6171d75c Net-FTPServer-1.122.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. X license field does not match the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Net::FTPServer) = 1.122 perl(Net::FTPServer::DBeg1::DirHandle) perl(Net::FTPServer::DBeg1::FileHandle) perl(Net::FTPServer::DBeg1::IOBlob) perl(Net::FTPServer::DBeg1::Server) perl(Net::FTPServer::DirHandle) perl(Net::FTPServer::FileHandle) perl(Net::FTPServer::Full::DirHandle) perl(Net::FTPServer::Full::FileHandle) perl(Net::FTPServer::Full::Server) perl(Net::FTPServer::Handle) perl(Net::FTPServer::InMem::DirHandle) perl(Net::FTPServer::InMem::FileHandle) perl(Net::FTPServer::InMem::Server) perl(Net::FTPServer::Proxy::DirHandle) perl(Net::FTPServer::Proxy::FileHandle) perl(Net::FTPServer::Proxy::Server) perl(Net::FTPServer::RO::DirHandle) perl(Net::FTPServer::RO::FileHandle) perl(Net::FTPServer::RO::Server) perl(Net::FTPServer::ZipMember) perl-Net-FTPServer = 1.122-3.fc9 = perl(:MODULE_COMPAT_5.10.0) perl(Authen::PAM) perl(BSD::Resource) perl(Carp) perl(Carp::Heavy) perl(Config) perl(DBI) perl(Errno) perl(Fcntl) perl(File::Sync) perl(File::Temp) perl(FileHandle) perl(Getopt::Long) perl(IO::Dir) perl(IO::File) perl(IO::Scalar) perl(IO::Scalar) >= 1.126 perl(IO::Seekable) perl(IO::Select) perl(IO::Socket) perl(IPC::Open2) perl(Net::FTP) perl(Net::FTPServer) perl(Net::FTPServer::DBeg1::DirHandle) perl(Net::FTPServer::DBeg1::FileHandle) perl(Net::FTPServer::DBeg1::IOBlob) perl(Net::FTPServer::DirHandle) perl(Net::FTPServer::FileHandle) perl(Net::FTPServer::Full::DirHandle) perl(Net::FTPServer::Full::FileHandle) perl(Net::FTPServer::Handle) perl(Net::FTPServer::InMem::DirHandle) perl(Net::FTPServer::InMem::FileHandle) perl(Net::FTPServer::Proxy::DirHandle) perl(Net::FTPServer::Proxy::FileHandle) perl(Net::FTPServer::RO::DirHandle) perl(Net::FTPServer::RO::FileHandle) perl(POSIX) perl(Socket) perl(Sys::Hostname) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=43, Tests=573, 20 wallclock secs ( 8.01 cusr + 1.28 csys = 9.29 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review