Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gabedit - GUI for computational chemistry https://bugzilla.redhat.com/show_bug.cgi?id=444426 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-05-08 14:54 EST ------- For 2.1.4-1: * dist tag - Please consider to use %?dist tag. http://fedoraproject.org/wiki/Packaging/DistTag * License - The license of this package is "MIT". * SourceURL - For sourceforge hosted sources, please refer to the section "Sourceforge.net" of http://fedoraproject.org/wiki/Packaging/SourceURL * Parallel make - Please use %{?_smp_mflags} for the platform where _smp_mflags is not set. * rpmlint issues: --------------------------------------------------------------- gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit210.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit211.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/Others/Gabedit206.iss gabedit.i386: E: wrong-script-interpreter /usr/share/doc/gabedit-2.1.4/utils/Others/gabeditRunGamess.csh "./csh" ----------------------------------------------------------------- Summary: - Please remove all pre-built arch-dependent files under %_docdir - Check if Gabedit21?.iss can be converted into UTF-8 (not a blocker) - Fix the shebang of gabeditRunGamess.csh By the way I would appreciate it if you would review my review request (bug 444933) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review