Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: portreserve - TCP port reservation utility https://bugzilla.redhat.com/show_bug.cgi?id=445687 ------- Additional Comments From jochen@xxxxxxxxxxxxxxx 2008-05-08 13:34 EST ------- Good: + Local build works fine + License look good + %doc section contains LICENSE file + Buildroot was cleaned on beginning of %install and %clean stanza Bad: - Rpmlint complaints on source RPM: rpmlint portreserve-0.0.1-1.fc8.src.rpm portreserve.src:23: W: make-check-outside-check-section make check portreserve.src: W: strange-permission portreserve.spec 0600 - Rpmlint complaints on binary RPM: $ rpmlint portreserve-0.0.1-1.fc8.x86_64.rpm portreserve.x86_64: W: service-default-enabled /etc/init.d/portreserve portreserve.x86_64: W: service-default-enabled /etc/init.d/portreserve portreserve.x86_64: E: subsys-not-used /etc/init.d/portreserve - Please don't use %makeinstall - Inconsistence use of macros /var/run vs. %{_localstatedir}/run - Please use %{_initrddir} for /etc/init.d - Build on mock (x86_64) failed: make all-am make[1]: Entering directory `/builddir/build/BUILD/portreserve-0.0.1' depbase=`echo src/portreserve.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ gcc -DHAVE_CONFIG_H -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT src/portreserve.o -MD -MP -MF $depbase.Tpo -c -o src/portreserve.o src/portreserve.c &&\ mv -f $depbase.Tpo $depbase.Po gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o src/portreserve src/portreserve.o xmlto man -o doc doc/portreserve.xml make[1]: execvp: xmlto: Permission denied make[1]: - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review