Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver Alias: comedilib-review https://bugzilla.redhat.com/show_bug.cgi?id=443797 ------- Additional Comments From lkundrak@xxxxx 2008-05-07 05:55 EST ------- Thanks for the package, and sorry for the delay. Here's the review: 1.) Source file is not available for download. Probably the correct URL is: http://www.comedi.org/comedi/download/comedilib-0.8.1.tar.gz 2.) You should not use %makeinstall macro. See this document for reason: http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall 3.) The build in mock failed for me. Seems like it did not generate python files, and failed to define %python_sitelib correctly. That might be because you omitted python-devel from BuildRequires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review