Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pywebkitgtk - Python Bindings for WebKit-gtk https://bugzilla.redhat.com/show_bug.cgi?id=443850 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-05-06 12:27 EST ------- For 0.3-0.1.git: * Versioning - According to NamingGuidelines, the EVR (Epoch-Version-Release) of this package should be: 0.3-0.1.<git_number>%{?dist}. * License - As far as I checked the whole codes in the source tarball, the license tag must be GPLv2+. - Rationale - webkit.override is under GPLv2+, and rebuild log says: --------------------------------------------------------------- 215 (cd .\ 216 && /usr/bin/pygtk-codegen-2.0 \ 217 --register /usr/share/pygtk/2.0/defs/gdk-types.defs \ 218 --register /usr/share/pygtk/2.0/defs/gtk-types.defs \ 219 --override webkit.override \ 220 --prefix pywebkit webkit.defs) 2>&1 >gen-webkit.c | tee webkit.errors \ 221 && ! grep -q -v "^\*\*\*INFO\*\*\*" webkit.errors \ 222 && cp gen-webkit.c webkit.c \ 223 && rm -f gen-webkit.c 229 /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/usr/include/python2.5 -I/usr/incl ude/pygtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/webkit-1.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -O2 -g -pipe -Wal l -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT webkit_la-webkit.lo -MD -MP -MF .deps/webkit_la-webkit.Tpo -c -o webkit_la-webkit. lo `test -f 'webkit.c' || echo './'`webkit.c 233 /bin/sh ./libtool --tag=CC --mode=link gcc -I/usr/include/pygtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/webkit-1.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -module -avoid-version -export-symbols-regex initwebkit -o webkit.la -rpath /usr/lib/python2.5/site-packages/gtk-2.0 webkit_la-webkitmodule.lo webkit_la-javascriptcore-types.lo webkit_la-webkit.lo -lwebkit-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 --------------------------------------------------------------- * Directory ownership issue - %{python_sitearch}/gtk-2.0/ is already owned by pygtk2 and pywebkitgtk should not own this directory. * libtool .la files - Please remove libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review