Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xxdiff https://bugzilla.redhat.com/show_bug.cgi?id=436677 ------- Additional Comments From thomas.moschny@xxxxxx 2008-05-06 04:31 EST ------- Some problems are still left. - CFLAGS/CFLAGS: The standard flags defined by the rpmbuild environment are not properly passed to the build process. As far as I see, this can't be done from the specfile, but needs patching the makefiles (sth. like passing additional QMAKE_CXXFLAGS and QMAKE_CFLAGS to qmake when bootstrapping the main makefile). This is a blocker issue imho. (If time permits I'll try to come up with a patch.) - Requirements: The main xxdiff packages should'nt depend on python. - Why don't you install the tool scripts into %python_sitelib (the commented out lines)? The tools package is architecture independent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review