Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jcommon-serializer - JFree Java General Serialization Framework https://bugzilla.redhat.com/show_bug.cgi?id=445085 ------- Additional Comments From loganjerry@xxxxxxxxx 2008-05-05 19:32 EST ------- Have you considered including ChangeLog.txt in %doc? Also, it seems weird to have the javadocs in %{_javadocdir}/jcommon-serializer/javadoc. Can you change this line in %install: cp -rp javadoc $RPM_BUILD_ROOT%{_javadocdir}/%{name} to this? cp -rp javadoc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name} MUST: - rpmlint output is empty except for: $ rpmlint jcommon-serializer-javadoc jcommon-serializer-javadoc.prescott: W: non-standard-group Development/Documentation - package name: OK - spec file name: OK - packaging guidelines: OK - license: OK - license file in %doc: OK - spec file in American English: OK - spec file is legible: OK - sources match upstream: OK - builds on one architecture: OK (i386) - use of ExcludeArch: OK - all dependencies in BuildRequires: OK - locales handled properly: OK - proper use of ldconfig: OK - relocatable package: OK - owns all directories it creates: FAIL, to fix replace this %files line: %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.* with this line: %attr(-,root,root) %{_libdir}/gcj/%{name} - no duplicate files: OK - permissions: OK - %clean section: OK - consistent use of macros: OK - code or permissible content: OK - large documentation in -doc: OK - nothing in %doc needed at runtime: OK - header files in -devel: OK - static libraries in -static: OK - require pkgconfig if needed: OK - .so files in -devel: OK - devel packages require base: OK - no libtool archives: OK - desktop file for GUI apps: OK - do not own already owned files or dirs: OK - %install cleans buildroot first: OK - all filenames are UTF-8: OK SHOULD: - license text file: OK - description and summary translations: OK - package builds in mock: OK (tested for i386 F-8 only) - builds on all supported architectures: did not check - package functions as described: did not check - sane scriptlets: OK - subpackages require main package: OK - pkgconfig file placement: OK - file dependencies: OK Summary: 1. MUST fix the gcj directory ownership issue. 2. PLEASE consider ChangeLog.txt for %doc. 3. PLEASE consider shortening the javadoc path as described above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review