Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ale - Combines multiple inputs of the same scene https://bugzilla.redhat.com/show_bug.cgi?id=443467 ------- Additional Comments From kwizart@xxxxxxxxx 2008-05-05 10:15 EST ------- (In reply to comment #4) > (In reply to comment #3) > > I forgot to say that the string.h tweak that is done at the begining seems > scary > > to me... I wonder why this is needed. (I will check futher...) > > Which string.h tweak? The cstring patch for GCC 4.3? see the build.log between rm -f string.h-t string.h and mv string.h-t string.h It makes use of a custom string.h - I wonder why ? (can you ask upstream?) see http://koji.fedoraproject.org/koji/taskinfo?taskID=595945 At least it build with all our platforms. /usr/bin/ale seems to need exiftool and dcraw, so it would be fine to have: Requires: perl-Image-ExifTool Requires: dcraw I also forgot to say that ale 0.9.0 is supposed to be the unstable branch, whereas 8.11 is the known stable. I'm still in runtime testing... maybe we can have 0.9.0 anyway. I don't know how work the --device (undocumented) option, maybe that what we can expect as improvement with 9.0 version (don't have such device also). >From the sources code, the device folder doesn't seems to have the headers compiled... Anyway, that would be optionnal for the review. To sum up: * Ask upstream about it's custom string.h * Add: Requires: perl-Image-ExifTool Requires: dcraw -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review