Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tlock - terminal lock https://bugzilla.redhat.com/show_bug.cgi?id=444952 ------- Additional Comments From rc040203@xxxxxxxxxx 2008-05-05 00:24 EST ------- Some progress, but there still are several issues: * MUSTFIX: Wrong License-tag: Package is licensed GPLv2+ (GPL version 2 or later), not GPLv2. => License: GPLv2+ * MUSTFIX: devel libraries in base package. Split out the devel files into a *-devel subpackage. (Devel files: lib*.so, *.h, *.3) * MUSTFIX: rpm-versions are missing in you %changelog entries * SHOULD: Please remove the line referring to "GPLv2" from %description. It's redundant to License: and legally questionable, because the actual and legally binding licenses are those inlined into the sources. * SHOULD: Spec uses "make -s". We want to see messages when building rpms. make -s is not useful when building rpms. Side-note to you as upstream: sizeof(char) is always 1. Apart from implicit type-casts, constructs such as malloc(pass_len * sizeof(char)) are pretty meaningless. You will likely want to change the type of pass_len to size_t instead of unsigned int, instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review