Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library Alias: perl-HTML-Prototype https://bugzilla.redhat.com/show_bug.cgi?id=439163 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-05-05 00:05 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=595441 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 33ff3781ce851506e4728f5f2b2a40de HTML-Prototype-1.48.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/01use............ ok t/02pod............ ok t/03podcoverage.... ok All tests successful. Files=3, Tests=17, 0 wallclock secs ( 0.62 cusr + 0.02 csys = 0.64 CPU) + Package perl-HTML-Prototype-1.48-2.fc9 => Provides: perl(HTML::Prototype) = 1.48 perl(HTML::Prototype::Controls) perl(HTML::Prototype::DragDrop) perl(HTML::Prototype::Effects) perl(HTML::Prototype::Helper) perl(HTML::Prototype::Helper::Tag) perl(HTML::Prototype::Js) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Class::Accessor::Fast) perl(HTML::Element) perl(HTML::Prototype::Controls) perl(HTML::Prototype::DragDrop) perl(HTML::Prototype::Effects) perl(HTML::Prototype::Helper) perl(HTML::Prototype::Helper::Tag) perl(HTML::Prototype::Js) perl(HTML::Tree) perl(base) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review