Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libacpi - General purpose library for ACPI https://bugzilla.redhat.com/show_bug.cgi?id=445153 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-05-04 20:06 EST ------- Please do not manually strip the debuginfo from the compiled binary files. Doing that breaks generation of the -debuginfo package. You should be consistent in using macros. /usr/share/doc and /usr/share/man should be replaced by %{_defaultdocdir} and %{_mandir}, respectively. Same goes for /usr/bin and /usr/include/. *.a files, _if_ they they have to be packaged should be placed in a separated libacpi-static rpm (see http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review