Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter https://bugzilla.redhat.com/show_bug.cgi?id=444356 rhbugs@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From rhbugs@xxxxxxxxxxxxxxxx 2008-05-04 01:41 EST ------- Review Guidelines MUST items: - [OK] rpmlint output: none - [OK] package name - [OK] %{name}.spec - [OK] Packaging Guidelines - [OK] Licensing Guidelines (MIT) - [OK] License Field in spec - [OK] License text in %doc - [OK] Spec file in en_US - [OK] legible spec file - [OK] source matches upstream - [OK] compiles successfully as noarch - [OK] BuildRequires - N/A %find_lang - N/A shared libs - N/A not relocatable - [OK] directory ownership - [OK] no duplicate files in %files - [OK] proper permissions on files, %defattr present - [OK] %clean section cleans %{buildroot} - [OK] consistently uses macros - [OK] package contains code - N/A large docs - [OK] %doc files do not affect runtime behaviour - N/A header files in -devel - N/A static libs in -static - N/A foo.pc files - N/A libfoo.so.1.1 - N/A no devel package - N/A no .la archives - N/A not a GUI app - [OK] Does not own files/dirs owned by other packages - [OK] %install cleans out %{buildroot} first - [OK] all filenames are valid ASCII and thus UTF-8 Review Guidelines SHOULD items: - N/A license text - N/A no translated descriptions available - [OK] builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=594044 - N/A noarch package - [OK] appears to work - N/A no scriptlets - N/A no sub-packages - N/A no foo.pc - N/A no file dependencies Remarks on Python Packaging Guidelines: - [OK] good python_sitelib macro definition - [OK] use %{python_sitelib} - N/A Not an egg, only builds .egg-info - [OK] Includes all byte compiled files Remarks on Packaging Guidelines: - package uses second allowed choice for BuildRoot: - CFLAGS="%{optflags}"... what for in a noarch package? - desktop file: - as non-GUI app bpython does not need one - it is non-functional - ergo: why not leave it out? If you do decide to add a desktop file starting bpython in a terminal: Please use %{__install}'s -p parameter. I'd change those three, but they are OK as-is. ACCEPTED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review