Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tlock - terminal lock https://bugzilla.redhat.com/show_bug.cgi?id=444952 ------- Additional Comments From rc040203@xxxxxxxxxx 2008-05-02 09:59 EST ------- This package suffers from several issues: 1. MUSTFIX: BuildRequires: ncurses is meaningless. You will want BuildRequires: ncurses-devel instead. Without it, this package doesn't build in mock at all. 2. MUSTFIX: Use %{_bindir}, %{_libdir}, %{_infodir}, %{_mandir} in %files instead of %_prefix/bin/tlock %_prefix/lib/* %_prefix/share/info/* %_prefix/share/man/* Additionally, using %_prefix/lib also breaks building this package on 64bit targets. 3. MUSTFIX: Source0: must be an URL pointing to the tarball (http://pjp.dgplug.org/tools/%{name}-%{version}.tar.gz) not a relative filename. 4. MUSTFIX: Library packaging: - Package ships static library. If you really want to ship it, package the *.a into a separate package. If not, disable building it (Append --disable-static to %configure) - Package ships *.la. Remove it in %install. 5. MUSTFIX: Devel files in base package. Your base package %{name} contains development files, which are not needed at run time. Either do not ship them at all or move them into a separate %{name}-devel subpackage 6. MUSTFIX: The info files are packaged incorrectly. Infos require special treatment in %post/%postun Check the FPG and/or how other packages do so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review