Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2008-05-02 09:13 EST ------- A few quick comments: 1. BuildRoot: /tmp/spicebird Use one of the suggested buildroots in the packaging guidelines. 2. Source0: spicebird-0.4.source.tar.bz2 This should be a full URL 3. Release: 0%{?dist} Start with 1 4. MOZ_OPT_FLAGS=$(echo $RPM_OPT_FLAGS | %{__sed} -e 's/-O2/-Os/' -e 's/-Wall//') ill-advised. I'd recommend omitting this. Also, good idea to try a scratch build in koji (I can help on irc if you don't know how to do that). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review