Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtksourceview2-sharp - gtksourceview2 C# binding https://bugzilla.redhat.com/show_bug.cgi?id=444721 gnomeuser@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From gnomeuser@xxxxxxxxx 2008-04-30 09:13 EST ------- Okay I promised I would take this, here goes a first glance: If it is a svn snapshot then the strongly prefered way to deal with this is labelling the package as such. An example of the syntax can be seen here: http://cvs.fedoraproject.org/viewcvs/rpms/WebKit/devel/WebKit.spec?view=markup Mono specs need the following line: ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha Can you explain what the rm -rf % line is intended to accomplice? Aside that rpmlint is silent and the spec is readable (though I would like comments as always when you do sed magic to explain what you do, it makes it easier for co-maintainers and people who care for your packages while you are on vacation/sick to follow along). Does not build in mock (fedora-devel-x86_64), needs to br gtk-sharp2-devel instead of gtk-sharp-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review