Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pem - Pem is personal expenses manager https://bugzilla.redhat.com/show_bug.cgi?id=444601 fedora@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2008-04-29 17:07 EST ------- REVIEW for cd9524c18ca7a86b1063b4b9f2b5c7d1 pem-0.7.1-1.fc9.src.rpm OK - MUST: no output from rpmlint OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package OK - MUST: package meets the Packaging Guidelines FAIL - SHOULD: %description should end with a dot OK - MUST: licensed with a Fedora approved license (GPLv2 only) OK - MUST: license field in the spec file matches the actual license OK - MUST: package includes a copy of the license text which is correctly installed in %doc OK - MUST: spec file is written in American English OK - MUST: spec file is legible OK - MUST: source matches upstream FAIL - MUST: source URL is wrong. Source0 should be http://pjp.dgplug.org/tools/%{name}-%{version}.tar.gz and URL http://pjp.dgplug.org/tools/ OK - MUST: package successfully compiles and builds into binary rpms on x86_64. OK - MUST: no ExcludeArch since this package is noarch OK - MUST: all build requirements are listed in BuildRequires OK - MUST: no locales to care about OK - MUST: no shared lib to care about OK - MUST: not relocatable OK - MUST: no directories to own OK - MUST: no duplicate files in the %files listing OK - MUST: permissions on files are set properly OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT OK - MUST: package uses macros consistently OK - MUST: package contains code not content OK - MUST: no large docs OK - MUST: docs don't affect runtime OK - MUST: no header files for a devel package OK - MUST: no static libs OK - MUST: no libtool archives OK - MUST: no GUI, so no %{name}.desktop needed OK - MUST: packages doesn't own files or directories already owned by other packages OK - MUST: BuildRoot is properly prepared at the beginning of %install OK - MUST: all filenames are valid UTF-8 OK - SHOULD: builds in mock OK - SHOULD: functions as described OK - SHOULD: Texinfo scriptlets are sane (taken from the wiki) APPROVED, if you fix the errors. As they are trivial you can do this after the cvs import but you NEED TO FIX them before build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review