Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rubygem-activeldap - LDAP APIs for Ruby https://bugzilla.redhat.com/show_bug.cgi?id=443248 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tcallawa@xxxxxxxxxx 2008-04-29 16:48 EST ------- Good: - rpmlint checks return: rubygem-activeldap.src: W: mixed-use-of-spaces-and-tabs (spaces: line 42, tab: line 10) Safe to ignore, since you're working with upstream to fix the generation script. - package meets naming guidelines - package meets packaging guidelines (general and ruby) - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (7aeaf58a819357bdf2044fd664db420d40aa15dd) - package builds on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review