Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xosview - OS resource viewer https://bugzilla.redhat.com/show_bug.cgi?id=434906 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-04-29 11:56 EST ------- For 1.8.3.cvsXXX-8: * Versioning - Well actually 1.8.3-cvsXXXX-8 is against Fedora naming guidelines. Please check the subsection "Snapshot packages" of http://fedoraproject.org/wiki/Packaging/NamingGuidelines The recommended EVR is 1.8.3-X.YYYYYYYcvs%{?dist} * %configure - %configure sets CXXFLAGS. You can check what %configure does by $ rpm --eval %configure . So for this package the following is enough. -------------------------------------------------- %build ./autogen.sh %configure %{__make} %{?_smp_mflags} all ..... -------------------------------------------------- Then as this is NEEDSPONSOR ticket, as I said in my comment 11 I wait for your another review request submission or your pre-review of other review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review