Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-04-29 11:03 EST ------- For 0.6.6-6: * License http://fedoraproject.org/wiki/Packaging/LicensingGuidelines - I checked the license of speech-dispatcher and * The base license of this is GPLv2+ * src/c/clients/spdsend/spdsend.h in the tarball is under GPL, which makes %_bindir/spdsend to be GPLv2: So * Please change the license tag of all packages except speech-dispatcher (main) pkg to "GPLv2+" * For speech-dispatcher, write in the spec file like below: ----------------------------------------------------------- Group: System Environment/Libraries # Almost all files are under GPLv2+, however # src/c/clients/spdsend/spdsend.h is licensed under GPLv2, # which makes %%_bindir/spdsend GPLv2. License: GPLv2+ and GPLv2 URL: http://www.freebsoft.org/pub/projects/speechd/ ----------------------------------------------------------- * Requires(%post,etc) - Why are /sbin/chkconfig, /sbin/service needed for Requires(%post,etc)? * %install process - Would you clean up %install scripts (like following)? ----------------------------------------------------------- for dir in \ config doc src/audio c ..... do pushd $dir make install DESTDIR=$RPM_BUILD_ROOT popd done ----------------------------------------------------------- * Documents - Adding "COPYING" to %doc is rather mandatory if it exists. * rpmlint issue ----------------------------------------------------------- speech-dispatcher-doc.i386: W: file-not-utf8 /usr/share/info/speech-dispatcher-cs.info.gz speech-dispatcher-devel.i386: W: no-documentation speech-dispatcher-python.i386: W: no-documentation speech-dispatcher.i386: E: non-empty-%postun /sbin/ldconfig speech-dispatcher-python.i386: E: non-executable-script /usr/lib/python2.5/site-packages/speechd/_test.py 0644 speech-dispatcher.i386: E: postun-without-ldconfig /usr/lib/libspeechd.so.2.0.5 ----------------------------------------------------------- Summary - Please change the encodings of the files in warning to UTF-8. - Scripts without execution permission should not have shebangs - For /sbin/ldconfig error: ----------------------------------------------------------- %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ######################################################### <---- # MAIN PACKAGE FILES <---- ######################################################### <---- %files ----------------------------------------------------------- If you write any comments %postun and %files, this is interpreted that you want to execute the script with the content written as a comment _with the interpreter /sbin/ldconfig_ , which is wrong. In short When just calling /sbin/ldconfig on %post(un,etc) scriptlets in one line, don't write any comments after that. * Binary name - IMO the names of the binaries ----------------------------------------------------------- %_bindir/long_message %_bindir/run_test ----------------------------------------------------------- are too generic. Would you rename these binaries? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review