Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-themes - Themes for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254058 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2008-04-28 22:15 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT with advertising) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 20fbaff803c3decdf3ac7c363b37c42e e16-themes-0.16.8.0.2.tar.gz 20fbaff803c3decdf3ac7c363b37c42e e16-themes-0.16.8.0.2.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. As per usual, you might ask upstream to relicense. ;) 2. rpmlint says: e16-themes.noarch: E: zero-length /usr/share/e16/themes/BlueSteel/slideouts/slideouts.cfg e16-themes.noarch: E: zero-length /usr/share/e16/themes/BlueSteel/buttons/buttons.cfg e16-themes.noarch: E: zero-length /usr/share/e16/themes/BrushedMetal-Tigert/buttons/buttons.cfg e16-themes.noarch: E: zero-length /usr/share/e16/themes/BrushedMetal-Tigert/slideouts/slideouts.cfg e16-themes.noarch: E: zero-length /usr/share/e16/themes/BlueSteel/sound/sound.cfg I am guessing that these zero-length files are needed? If not, it would be nice not to ship them... can you confirm? e16-themes.noarch: W: invalid-license MIT with advertising e16-themes.src: W: invalid-license MIT with advertising Ignore. None of those are really blockers. If you can check on the zero-length files and ping upstream before importing that would be great. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review