Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GMT - Generic Mapping Tools https://bugzilla.redhat.com/show_bug.cgi?id=438043 ------- Additional Comments From pertusus@xxxxxxx 2008-04-28 18:33 EST ------- Could it be possible to have the doc package submitted in parallel? I agree that it is a good idea to have a separate doc package, to have a noarch package. You should look at my package for the removal of a non-free file. I find the octave patch a bit strange, since it uses matlab support. Could it be possible to have it additionally, such that it can be submitted upstream? Your octave packaging is not the same than the one proposed at: http://fedoraproject.org/wiki/PackagingDrafts/Octave but at that page there are mistakes. There is no soname in the shared libs. Do you really want to ship them? I think it is very wrong. The octave define at the beginning should be ameliorated, I get, without octave-devel: $ rpmbuild -ba GMT.spec sh: octave-config: command not found sh: octave-config: command not found sh: octave-config: command not found sh: octave-config: command not found sh: octave-config: command not found sh: octave-config: command not found sh: octave-config: command not found error: Failed build dependencies: octave-devel is needed by GMT-4.2.1-2.i386 I propose to have xgridedit in a separate package, to avoid depending on the X libs. less is detected at build time and used in the GMT script at runtime. There are many config files in %_datadir that cannot be overriden by the user. They should be in %_sysconfdir and marked %config(noreplace). The coresponding code in my spec is: %define gmthome %{_datadir}/GMT %define gmtconf %{_sysconfdir}/GMT mkdir -p $RPM_BUILD_ROOT%{gmtconf}/{mgg,dbase,mgd77,conf} pushd $RPM_BUILD_ROOT%{gmthome}/ # remove unneeded file rm conf/gmt.conf.orig # put conf files in %{gmtconf} and do links in %{gmthome} for file in conf/*.conf mgg/gmtfile_paths dbase/grdraster.info \ mgd77/mgd77_paths.txt; do mv $file $RPM_BUILD_ROOT%{gmtconf}/$file # absolute links # ln -s %{gmtconf}/$file $RPM_BUILD_ROOT%{gmthome}/$file # relative link ln -s ../../../../../%{gmtconf}/$file $RPM_BUILD_ROOT%{gmthome}/$file done popd %dir %{gmtconf} %dir %{gmtconf}/mgg %dir %{gmtconf}/dbase %dir %{gmtconf}/mgd77 %dir %{gmtconf}/conf %config(noreplace) %{gmtconf}/conf/*.conf %config(noreplace) %{gmtconf}/mgg/gmtfile_paths %config(noreplace) %{gmtconf}/dbase/grdraster.info %config(noreplace) %{gmtconf}/mgd77/mgd77_paths.txt Also I have a sed substitution to correct the doc path in the GMT command. The doc path may be different in your package, but you could adapt: -e 's:\${prefix}/www/gmt/gmt_services.html:%{_docdir}/%{name}-%{version}/gmt_services.html:' src/GMT I suggest adding INSTALL='install -p' to the make install command to keep timestamps as much as possible. Also during install, cp is called as cp -r for installation of data. I would suggest either substituting cp -r to cp -pr, redoing the install or doing a patch for the Makefile to keep timestamps. I suggest doing in %prep: chmod a-x src/ps2raster.c src/mgd77/mgd77sniffer.c pslib is a badly choosed name, it could interfere with other library names. I did: # rename the pslib man page mv $RPM_BUILD_ROOT%{_mandir}/man3/pslib.3 $RPM_BUILD_ROOT%{_mandir}/man3/GMT_pslib.3 The examples should certainly be %doc, even if they are in a separate package, since they are really %doc, and we don't want them to be installed if docs are excluded. The html docs should be in the main package, they are very small. The src/*/README.* should also be in %doc. I think that it would be better to have a %dist tag. I think that the examples should have a Requires: %{name} = %{version}-%{release} such that there cannot be any mismatch which could cause the examples to fail. I propose adding to main package %doc gmt_bench-marks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review