Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: deco - Extractor for various archive file formats https://bugzilla.redhat.com/show_bug.cgi?id=444366 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-04-28 06:34 EST ------- Just a note after a quick glance over the spec: - "Source0:" should include the full path to the downloadable source file, i.e. http://hartlich.com/deco/download/deco-0.8.1.tar.gz - you should not use absolute paths in the spec, but macros. hence all occurrences of "/usr" should be replaced by "%{_prefix}", "/usr/bin/" by "%_bindir" and "/usr/share/" by "%{_datadir}" - /usr/share/deco is not owned by anyone And just as a mater of curiosity: wouldn't it be simpler to use "%{_datadir}/deco/*" (or even "%{_datadir}/%{name}") in %files, instead of listing all individual components ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review