Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squirrel - high level imperative/OO programming language https://bugzilla.redhat.com/show_bug.cgi?id=442280 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-04-27 08:38 EST ------- There are a couple of small changes that you should make to the spec: * your build section does not make use of the SMP flags (see Packaging/Guidelines#parallelmake); fixable by adding %{?_smp_mflags} to the make line in %build * preserving timestamps; partially fixable by adding INSTALL="install -p" to the " %make install " line in %install; this will the timestamps for files included in squirrel-devel and squirrel-debuginfo. A nice touch would be to use "touch -r "in order to also preserve preserve the timestamps of the 3 files modified via sed (in %prep) * Each %files section should have a %defattr line (wiki: Packaging/ReviewGuidelines) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review