Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI https://bugzilla.redhat.com/show_bug.cgi?id=443374 ------- Additional Comments From rjones@xxxxxxxxxx 2008-04-25 10:33 EST ------- - rpmlint output openhpi-subagent.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/openhpi-subagent openhpi-subagent.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/openhpi-subagent openhpi-subagent.i386: W: service-default-enabled /etc/rc.d/init.d/openhpi-subagent openhpi-subagent.i386: W: service-default-enabled /etc/rc.d/init.d/openhpi-subagent Apparently init scripts shouldn't be marked as %config, so just remove that annotation. If the init script is intended to be edited, then you should create a config file under /etc/sysconfig and have the init file source that config file. The service should be disabled by default. http://fedoraproject.org/wiki/Packaging/SysVInitScript#head-c074b6a78b42c4c797d978750719ebcf262b4e61 + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture i386 n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available - reviewer should build the package in mock (but koji build, so no need) + the package should build into binary RPMs on all supported architectures - review should test the package functions as described + scriptlets should be sane but see above n/a pkgconfig files should go in -devel n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin ---------- The only issues are those problems found by rpmlint. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review