Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: speex https://bugzilla.redhat.com/show_bug.cgi?id=226428 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(matthias@rpmforge.| |net) | ------- Additional Comments From matthias@xxxxxxxxxxxx 2008-04-25 07:05 EST ------- OK, one last minor thing : The %{_defaultdocdir}/speex line isn't needed. I see this was supposed to fix bug #439284 but I think it's wrong as the /usr/share/doc/speex directory isn't included in the package. Also, you should escape the macro in the %changelog by putting %%{_defaultdocdir}/speex so that it doesn't get expanded to the value in there. The rest looks all good, modulo some weird (yet very minor) tabs and spaces mixing inside the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review