Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls https://bugzilla.redhat.com/show_bug.cgi?id=438105 ------- Additional Comments From s-t-rhbugzilla@xxxxxxxxxxxxx 2008-04-21 21:03 EST ------- I have a few more comments since the .spec has been updated. 1) The .spec in the SRPM and the separate URL you posted don't quite match; only 1 has a "BuildRequires: python". For completeness of review, these should match. 2) You may as well use %{mainpkg} to replace both instances of "concordance" in the Source0 URL. 3) In the %setup line, %name should be %{name}. At least for consistency, even if not functionality. 4) I believe the canonical hostname for SF downloads is downloads.sourceforge.net, not internap.dl.sourceforget.net (Source0 URL) 5) I don't think "%files ../xxx" is legal. Instead, I think you need to install those files in %install, then package them from the installation directory. Take a look at fftw2 or cmigemo (I looked at devel branches) for other .spec files that work this way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review