Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4 https://bugzilla.redhat.com/show_bug.cgi?id=443310 martin.sourada@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From martin.sourada@xxxxxxxxx 2008-04-20 11:50 EST ------- (In reply to comment #4) > (In reply to comment #2) > > URL was not correct so I've uploaded the sources in your stead to speed up the > > review. > thanks > > (In reply to comment #3) > > Oh and I missed the srpm rpmlint output: > > xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install > > xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > > line 30) > > My bad, I did not rpmlint the package. Both fixed in > http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec > You want me to do another SRPM? Nice, that's acceptable. Would be better though, to bump the release number and mention the fixes in the %%changelog (and post new srpm here), but I do not require it. ACCEPTED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review