Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=443301 Summary: Review Request: concordance - Logitech Harmony Remote Control Update Utility Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: dev@xxxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: fedora-package-review@xxxxxxxxxx,notting@xxxxxxxxxx Spec URL: SRPM URL: http://dev.nigelj.com/SRPMS/concordance-0.20-1.fc8.src.rpm Description: Concordance enables users of the Logitech Harmony series of universal remote controls to update their firmware and configuration information from within linux. rpmlint issues: libconcord-devel.x86_64: W: no-documentation libconcord-perl.x86_64: W: no-documentation libconcord-python.x86_64: W: no-documentation There is no suitable documentation... libconcord-perl.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/concord/concord.bs I'm not 100% sure about this one, if someone can confirm it's not needed, then I'll %exclude in next revision libconcord-perl.x86_64: W: perl-temp-file /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/perllocal.pod Ditto libconcord-perl.x86_64: E: non-standard-executable-perm /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/concord/concord.so 0555 Seems to match other similar files. Nothing seems critical to me... Just as a note though... I've had a hell of a job getting the configure scripts to understand LDFLAGS/CFLAGS in places, hence the patches and sed's so per guidelines ( Adding to and overriding or filtering parts of these flags is permitted if there's a good reason to do so; the rationale for doing so should be reviewed and documented in the specfile especially in the override and filter cases.) I've done the patching... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review