Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cwiid - Library and tools for comunicating with a wiimote https://bugzilla.redhat.com/show_bug.cgi?id=441072 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-04-19 14:12 EST ------- Well, for 0.6.00-2: * BuildRequies: - python-devel requires python so "BuildRequires: python" is redundant. * Requires - Please check Requires for cwiid-devel package. %_includedir/cwiid.h contains: ---------------------------------------------------------- 62 #include <time.h> 63 #include <bluetooth/bluetooth.h> /* bdaddr_t */ 64 ---------------------------------------------------------- This means cwiid-devel must have "Requies: bluez-libs-devel" * License: - The license tag is a bit complex. * wminput/action_enum.txt is GPLv2 (not GPLv2+) * And this file is used as: ---------------------------------------------------------- 198 gawk -f action_enum.awk action_enum.txt > action_enum.c 210 gcc -g -Wall -W -DHAVE_CONFIG_H -I/builddir/build/BUILD/cwiid-0.6.00/common/include -I../libcwiid -DWMINPUT_CONFIG_DIR=\"/etc/cwiid/wminput\" -DCWIID_PLUGINS_DIR=\"/usr/lib/cwiid/plugins\" -I/usr/include/python2.5 -c -o action_enum.o action_enum.c 227 gcc -o wminput main.o conf.o c_plugin.o uinput.o action_enum.o util.o py_plugin.o parser.o lexer.o -L../libcwiid -rdynamic -lcwiid -ldl -lpython2.5 ---------------------------------------------------------- So %_bindir/wminput is GPLv2. As a result, please change the license tag of -wminput to "GPLv2". * Compilation flags - Fedora specific compilation flags are not correctly honored. ---------------------------------------------------------- 164 make[1]: Entering directory `/builddir/build/BUILD/cwiid-0.6.00/libcwiid' 165 gcc -g -Wall -W -DHAVE_CONFIG_H -I/builddir/build/BUILD/cwiid-0.6.00/common/include -fpic -c -o bluetooth.o bluetooth.c ---------------------------------------------------------- You can check what flags Fedora uses on compilation by "$ rpm --eval %optflags" * Directory ownership issue - Please make it sure that the directory created when installing a rpm is owned by the rpm. For example, the directory %_libdir/cwiid is not owned by any package. * static archive - Remove static archive unless needed. "Exclusion of Static Libraries" of http://fedoraproject.org/wiki/Packaging/Guidelines * GUI app - as %{_bindir}/wmgui is GUI program, an appropriate desktop file must be installed. Check the section "Desktop files" of http://fedoraproject.org/wiki/Packaging/Guidelines * Documents - Please add "AUTHORS" to %doc - Also adding "NEWS" is preferable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review