Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsel -- manipulate the X selection https://bugzilla.redhat.com/show_bug.cgi?id=416471 ------- Additional Comments From pertusus@xxxxxxx 2008-04-19 10:13 EST ------- Issues: CFLAGS="$RPM_OPT_FLAGS", and --prefix=%{_prefix} --libdir=%{_libdir} are automatically set in %configure. The CDEBUGFLAGS setting doesn't seems to be useful. I suggest to break %changelog lines at about 80 columns and use - signs to create lists: - Version upgrade. - Change license to MIT Old Style. - Fix URL, Requires, BuildRequires. - Change group to Applications/System like xclip. Include keywords in the description to make it easier to find. Remarks: The application compile flags are still present, but they don't look harmful to me. rpmlint says (wrongly) xsel.i386: W: no-version-in-last-changelog xsel-debuginfo.i386: W: no-version-in-last-changelog It works well. Match upstream 75983f143ce83dc259796c6eaf85c8f5 xsel-1.2.0.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review